We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--all-features
Should we test --all-features in our CI?
It seems some features could not be compiled in pallet-collective and pallet-xcm, I found this problem in #45
pallet-collective
pallet-xcm
error[E0046]: not all trait items implemented, missing: `successful_origin` --> /Users/clearloop/.cargo/git/checkouts/substrate-7e08433d4c370a21/68cfc32/frame/collective/src/lib.rs:884:1 | 884 | / impl< 885 | | O: Into<Result<RawOrigin<AccountId, I>, O>> + From<RawOrigin<AccountId, I>>, 886 | | AccountId: Default, 887 | | I, ... | 900 | | } 901 | | } | |_^ missing `successful_origin` in implementation | = help: implement the missing item: `fn successful_origin() -> OuterOrigin { todo!() }` error[E0046]: not all trait items implemented, missing: `successful_origin` --> /Users/clearloop/.cargo/git/checkouts/substrate-7e08433d4c370a21/68cfc32/frame/collective/src/lib.rs:904:1 | 904 | / impl< 905 | | O: Into<Result<RawOrigin<AccountId, I>, O>> + From<RawOrigin<AccountId, I>>, 906 | | N: U32, 907 | | AccountId, ... | 921 | | } 922 | | } | |_^ missing `successful_origin` in implementation | = help: implement the missing item: `fn successful_origin() -> OuterOrigin { todo!() }` error[E0046]: not all trait items implemented, missing: `successful_origin` --> /Users/clearloop/.cargo/git/checkouts/substrate-7e08433d4c370a21/68cfc32/frame/collective/src/lib.rs:927:1 | 927 | / impl< 928 | | O: Into<Result<RawOrigin<AccountId, I>, O>> + From<RawOrigin<AccountId, I>>, 929 | | N: U32, 930 | | D: U32, ... | 945 | | } 946 | | } | |_^ missing `successful_origin` in implementation | = help: implement the missing item: `fn successful_origin() -> OuterOrigin { todo!() }` error[E0046]: not all trait items implemented, missing: `successful_origin` --> /Users/clearloop/.cargo/git/checkouts/substrate-7e08433d4c370a21/68cfc32/frame/collective/src/lib.rs:951:1 | 951 | / impl< 952 | | O: Into<Result<RawOrigin<AccountId, I>, O>> + From<RawOrigin<AccountId, I>>, 953 | | N: U32, 954 | | D: U32, ... | 969 | | } 970 | | } | |_^ missing `successful_origin` in implementation | = help: implement the missing item: `fn successful_origin() -> OuterOrigin { todo!() }` Compiling pallet-multisig v3.0.0 (https://github.com/paritytech/substrate.git?branch=rococo-v1#68cfc326) error: aborting due to 4 previous errors For more information about this error, try `rustc --explain E0046`. error: could not compile `pallet-collective` To learn more, run the command again with --verbose. warning: build failed, waiting for other jobs to finish... error[E0046]: not all trait items implemented, missing: `successful_origin` --> /Users/clearloop/.cargo/git/checkouts/polkadot-4038f27d5e4ea2e8/943038a/xcm/pallet-xcm/src/lib.rs:162:1 | 162 | / impl<O: OriginTrait + From<Origin>, F: Filter<MultiLocation>> EnsureOrigin<O> for EnsureXcm<F> 163 | | where O::PalletsOrigin: From<Origin> + TryInto<Origin, Error=O::PalletsOrigin> 164 | | { 165 | | type Success = MultiLocation; ... | 181 | | } 182 | | } | |_^ missing `successful_origin` in implementation | = help: implement the missing item: `fn successful_origin() -> OuterOrigin { todo!() }` error: aborting due to previous error For more information about this error, try `rustc --explain E0046`. error: build failed
$ cargo test --all-features
The text was updated successfully, but these errors were encountered:
clearloop
Successfully merging a pull request may close this issue.
Summary
Should we test
--all-features
in our CI?It seems some features could not be compiled in
pallet-collective
andpallet-xcm
, I found this problem in #45Repreduce
$ cargo test --all-features
The text was updated successfully, but these errors were encountered: