Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PINT with --all-features in CI #46

Closed
clearloop opened this issue Apr 26, 2021 · 0 comments · Fixed by #71
Closed

Test PINT with --all-features in CI #46

clearloop opened this issue Apr 26, 2021 · 0 comments · Fixed by #71
Assignees
Labels
chore Maintenance related work p4 Low Priority

Comments

@clearloop
Copy link
Contributor

clearloop commented Apr 26, 2021

Summary

Should we test --all-features in our CI?

It seems some features could not be compiled in pallet-collective and pallet-xcm, I found this problem in #45

error[E0046]: not all trait items implemented, missing: `successful_origin`
   --> /Users/clearloop/.cargo/git/checkouts/substrate-7e08433d4c370a21/68cfc32/frame/collective/src/lib.rs:884:1
    |
884 | / impl<
885 | |     O: Into<Result<RawOrigin<AccountId, I>, O>> + From<RawOrigin<AccountId, I>>,
886 | |     AccountId: Default,
887 | |     I,
...   |
900 | |     }
901 | | }
    | |_^ missing `successful_origin` in implementation
    |
    = help: implement the missing item: `fn successful_origin() -> OuterOrigin { todo!() }`

error[E0046]: not all trait items implemented, missing: `successful_origin`
   --> /Users/clearloop/.cargo/git/checkouts/substrate-7e08433d4c370a21/68cfc32/frame/collective/src/lib.rs:904:1
    |
904 | / impl<
905 | |     O: Into<Result<RawOrigin<AccountId, I>, O>> + From<RawOrigin<AccountId, I>>,
906 | |     N: U32,
907 | |     AccountId,
...   |
921 | |     }
922 | | }
    | |_^ missing `successful_origin` in implementation
    |
    = help: implement the missing item: `fn successful_origin() -> OuterOrigin { todo!() }`

error[E0046]: not all trait items implemented, missing: `successful_origin`
   --> /Users/clearloop/.cargo/git/checkouts/substrate-7e08433d4c370a21/68cfc32/frame/collective/src/lib.rs:927:1
    |
927 | / impl<
928 | |     O: Into<Result<RawOrigin<AccountId, I>, O>> + From<RawOrigin<AccountId, I>>,
929 | |     N: U32,
930 | |     D: U32,
...   |
945 | |     }
946 | | }
    | |_^ missing `successful_origin` in implementation
    |
    = help: implement the missing item: `fn successful_origin() -> OuterOrigin { todo!() }`

error[E0046]: not all trait items implemented, missing: `successful_origin`
   --> /Users/clearloop/.cargo/git/checkouts/substrate-7e08433d4c370a21/68cfc32/frame/collective/src/lib.rs:951:1
    |
951 | / impl<
952 | |     O: Into<Result<RawOrigin<AccountId, I>, O>> + From<RawOrigin<AccountId, I>>,
953 | |     N: U32,
954 | |     D: U32,
...   |
969 | |     }
970 | | }
    | |_^ missing `successful_origin` in implementation
    |
    = help: implement the missing item: `fn successful_origin() -> OuterOrigin { todo!() }`

   Compiling pallet-multisig v3.0.0 (https://github.com/paritytech/substrate.git?branch=rococo-v1#68cfc326)
error: aborting due to 4 previous errors

For more information about this error, try `rustc --explain E0046`.
error: could not compile `pallet-collective`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error[E0046]: not all trait items implemented, missing: `successful_origin`
   --> /Users/clearloop/.cargo/git/checkouts/polkadot-4038f27d5e4ea2e8/943038a/xcm/pallet-xcm/src/lib.rs:162:1
    |
162 | / impl<O: OriginTrait + From<Origin>, F: Filter<MultiLocation>> EnsureOrigin<O> for EnsureXcm<F>
163 | |     where O::PalletsOrigin: From<Origin> + TryInto<Origin, Error=O::PalletsOrigin>
164 | | {
165 | |     type Success = MultiLocation;
...   |
181 | |     }
182 | | }
    | |_^ missing `successful_origin` in implementation
    |
    = help: implement the missing item: `fn successful_origin() -> OuterOrigin { todo!() }`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0046`.
error: build failed

Repreduce

$ cargo test --all-features

@clearloop clearloop added the needs triage Issue needs to be triaged label Apr 26, 2021
@dutterbutter dutterbutter added chore Maintenance related work p4 Low Priority and removed needs triage Issue needs to be triaged labels Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related work p4 Low Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants