Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate protoc-gen target, make it part of build target #24

Closed
guowenjian90 opened this issue May 11, 2022 · 0 comments
Closed

automate protoc-gen target, make it part of build target #24

guowenjian90 opened this issue May 11, 2022 · 0 comments

Comments

@guowenjian90
Copy link
Contributor

there are two issues stopping automate protobuf generate in build.

1/ generating go types and grpc stub requires protoc and these two go protoc plugins.
protoc has to be installed separately using ' apt install protobuf-compiler' which I have not automate it in Makefile.

2/ there is a another argoproj/argo-rollouts#1091 (comment), actually need to modify a few k8s files code to set full package name to work around it.

tried to use 'M' go_opt when execute protoc, but not working, has to manually modify a few generated a few k8s protobuf files
to use full package name, files are listed in Makefile.

	--go_opt=Mk8s.io/api/core/v1/generated.proto=k8s.io/api/core/v1 \
	--go_opt=Mk8s.io/apimachinery/pkg/api/resource/generated.proto=k8s.io/apimachinery/pkg/api/resource \
	--go_opt=Mk8s.io/apimachinery/pkg/apis/meta/v1/generated.proto=k8s.io/apimachinery/pkg/apis/meta/v1 \
	--go_opt=Mk8s.io/apimachinery/pkg/runtime/generated.proto=k8s.io/apimachinery/pkg/runtime \
	--go_opt=Mk8s.io/apimachinery/pkg/runtime/schema/generated.proto=k8s.io/apimachinery/pkg/runtime/schema \
	--go_opt=Mk8s.io/apimachinery/pkg/util/intstr/generated.proto=k8s.io/apimachinery/pkg/util/intstr \
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant