Closes #2393: Fix add dataset button visibility on installations with required email confirmation (#2408)

Author: madryk

dataverse-webapp/src/main/java/edu/harvard/iq/dataverse/DataverseHeaderFragment.java

@@ -24,7 +24,6 @@
 import java.net.URLDecoder;
 import java.util.ArrayList;
 import java.util.List;
-import java.util.UUID;
 import java.util.function.Function;
 import java.util.logging.Level;
 import java.util.logging.Logger;
@@ -109,10 +108,14 @@ public void initBreadcrumbsForDataFile(DataFile datafile, String subPage) {
         initBreadcrumbsForFileMetadata(fmd, subPage);
     }
 
-    public Boolean shouldShowUnconfirmedMailInfoBanner() {
+    public boolean shouldShowUnconfirmedMailInfoBanner() {
         return confirmEmailService.hasEffectivelyUnconfirmedMail(dataverseSession.getUser());
     }
 
+    public boolean shouldShowAddDatasetButton() {
+        return dataverseSession.getUser().isAuthenticated() && !confirmEmailService.hasEffectivelyUnconfirmedMail(dataverseSession.getUser());
+    }
+
     public void initBreadcrumbsForFileMetadata(FileMetadata fmd, String subPage) {
         if (fmd == null) {
             return;

dataverse-webapp/src/main/webapp/dataverse_header.xhtml

@@ -158,7 +158,7 @@
                 <div class="main-menu-container">
                     <nav class="main-menu">
                         <ul class="nav navbar-nav">
-                            <li jsf:rendered="#{dataverseSession.user.authenticated}">
+                            <li jsf:rendered="#{dataverseHeaderFragment.shouldShowAddDatasetButton()}">
                                 <h:form styleClass="navbar-form navbar-left navbar-form-link navbar-highlighted-link">
                                     <p:commandLink action="#{CreateDatasetDialog.init()}" update="create-dataset-dialog"
                                                    oncomplete="primeFacesShowModal('createDatasetDialog', this)">