From 35862e6cfe63c00e2dcd6b1cd97639fd29b34694 Mon Sep 17 00:00:00 2001 From: Lennart Braun Date: Tue, 11 Feb 2025 22:47:35 +0100 Subject: [PATCH] Allow HTTP*S* URLs for the HTTP(S) proxy setting (#1276) Make the regular expression used to check the validity of the "HTTP(S) proxy" setting less restrictive such that not only `http://, but also `https://` URLs are allowed. Fixes #1269 --- .../nutomic/syncthingandroid/activities/SettingsActivity.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/com/nutomic/syncthingandroid/activities/SettingsActivity.java b/app/src/main/java/com/nutomic/syncthingandroid/activities/SettingsActivity.java index fc632b5ed..5cb37c785 100644 --- a/app/src/main/java/com/nutomic/syncthingandroid/activities/SettingsActivity.java +++ b/app/src/main/java/com/nutomic/syncthingandroid/activities/SettingsActivity.java @@ -1176,7 +1176,7 @@ private boolean handleHttpProxyPreferenceChange(Preference preference, String ne if (newValue.equals("")) { preference.setSummary(getString(R.string.do_not_use_proxy) + " " + getString(R.string.generic_example) + ": " + getString(R.string.http_proxy_address_example)); return true; - } else if (newValue.matches("^http://.*:\\d{1,5}$")) { + } else if (newValue.matches("^https?://.*:\\d{1,5}$")) { preference.setSummary(getString(R.string.use_proxy) + " " + newValue); return true; } else {