You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Fix Incorrect Backend SVC for Default IngressRoutes (#441)
- Fixed bug where the Traefik IngressRoute generated via `reconcile` for an
`isDefault` ringed service was pointing to a non-existent backend k8s service
when `k8sBackend` is not provided.
- Cause: Incorrect computed value for the IngressRoute
`spec.routes[].services[].name`; was falling back to `metadata.name` when
`k8sBackend` was no provided -- which did does not contain the `ringName`.
- Fix: Expand logic for computing the IngressRoute `metadata.name`.
1. Always compute the _ringed_ version of the service name.
2. Use the _ringed_ service name for `metadata.name` when not `isDefault` --
use non-ringed otherwise.
3. Use the _ringed_ service name as fallback for the backing k8s service if
`k8sBackend` not provided -- otherwise compute the _ringed_ `k8sBackend`.
Co-authored-by: Michael Tarng <[email protected]>
0 commit comments