Skip to content

Cannot download files for comics beginning with a number #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajurna opened this issue May 31, 2023 · 0 comments
Closed

Cannot download files for comics beginning with a number #40

ajurna opened this issue May 31, 2023 · 0 comments
Labels
bug Report of something not working as expected contributing Request to contribute

Comments

@ajurna
Copy link
Contributor

ajurna commented May 31, 2023

Description of the bug
cannot download files for comic "100 Bullets"

To Reproduce
add 100 bullets
search for a download
it will blacklist any release without downloading.
[2023-05-31 12:46:21][waitress-3][INFO] Adding download for volume 1: https://getcomics.org/dc/100-bullets-1-100/
[2023-05-31 13:21:19][waitress-3][INFO] Adding https://getcomics.org/dc/100-bullets-1-100/ to blocklist with reason "No supported or working links"

Expected behaviour
the files to download

Screenshots

Version info

Additional context
i have narrowed the issue down to here https://github.com/Casvt/Kapowarr/blob/development/backend/files.py#L273

this regex (series_regex https://github.com/Casvt/Kapowarr/blob/development/backend/files.py#L56) seems to be designed to remove all numbers at the start of a name.

when this returns it will have the series named "Bullets" which will not match the files "100 Bullets" and cause it to fail. I think this would cause any series that begins with a number to fail to download.

@ajurna ajurna added the bug Report of something not working as expected label May 31, 2023
@Casvt Casvt moved this to In Testing in Kapowarr plans Jun 26, 2023
@Casvt Casvt added the contributing Request to contribute label Jul 11, 2023
@Casvt Casvt moved this from In Testing to Done in Kapowarr plans Jul 13, 2023
@Casvt Casvt closed this as completed Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of something not working as expected contributing Request to contribute
Projects
Archived in project
Development

No branches or pull requests

2 participants