From 294c232f644b9df13fb6cc7af66594a84886a305 Mon Sep 17 00:00:00 2001 From: Mateo Di Loreto Date: Thu, 16 Jul 2026 21:27:28 -0300 Subject: [PATCH] fix(ci): stop gating upstream-sync CI on checks that never run carto-upstream-sync-ready-checker.yml and carto-upstream-sync-ci-fixer.yml both listened for "LiteLLM Mock Tests (folder - tests/test_litellm)" and "LiteLLM Linting" alongside CARTO's own Docker CI. Neither of the first two can ever complete for these PRs: - "LiteLLM Mock Tests" is upstream-deprecated - its pull_request trigger is commented out, workflow_dispatch only (see test-litellm.yml). - "LiteLLM Linting" only triggers for PRs against upstream's own branches (main, litellm_internal_staging, litellm_oss_branch, litellm_**) - never carto/main, so it never runs against upstream-sync/* PRs either. Only "CARTO - Deploy Docker Image (CI)" actually exercises these PRs, so that's the only workflow_run trigger they need. --- .github/workflows/carto-upstream-sync-ci-fixer.yml | 7 +++++-- .github/workflows/carto-upstream-sync-ready-checker.yml | 7 +++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/workflows/carto-upstream-sync-ci-fixer.yml b/.github/workflows/carto-upstream-sync-ci-fixer.yml index 0f3e8eb03949..cd639fea3ca2 100644 --- a/.github/workflows/carto-upstream-sync-ci-fixer.yml +++ b/.github/workflows/carto-upstream-sync-ci-fixer.yml @@ -6,10 +6,13 @@ name: CARTO Upstream Sync - CI Fixer on: workflow_run: + # "LiteLLM Mock Tests" is upstream-deprecated (workflow_dispatch only, no + # pull_request trigger) and "LiteLLM Linting" only triggers for PRs against + # upstream's own branches (main, litellm_*), never carto/main - so neither + # ever completes for these PRs. CARTO's own Docker CI is the only check + # that actually runs against upstream-sync/* branches. workflows: - - "LiteLLM Mock Tests (folder - tests/test_litellm)" - "CARTO - Deploy Docker Image (CI)" - - "LiteLLM Linting" types: - completed branches: diff --git a/.github/workflows/carto-upstream-sync-ready-checker.yml b/.github/workflows/carto-upstream-sync-ready-checker.yml index 05b849c57408..45eb89adb61b 100644 --- a/.github/workflows/carto-upstream-sync-ready-checker.yml +++ b/.github/workflows/carto-upstream-sync-ready-checker.yml @@ -6,10 +6,13 @@ name: CARTO Upstream Sync - Ready Checker on: workflow_run: + # "LiteLLM Mock Tests" is upstream-deprecated (workflow_dispatch only, no + # pull_request trigger) and "LiteLLM Linting" only triggers for PRs against + # upstream's own branches (main, litellm_*), never carto/main - so neither + # ever completes for these PRs. CARTO's own Docker CI is the only check + # that actually runs against upstream-sync/* branches. workflows: - - "LiteLLM Mock Tests (folder - tests/test_litellm)" - "CARTO - Deploy Docker Image (CI)" - - "LiteLLM Linting" types: - completed branches: