Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toString() method for Animation expression #1381

Open
elenatorro opened this issue Jul 5, 2019 · 0 comments
Open

Fix toString() method for Animation expression #1381

elenatorro opened this issue Jul 5, 2019 · 0 comments
Labels

Comments

@elenatorro
Copy link
Contributor

Context

When creating an AnimationGeneral class, on the _init function we're adding the progress to the animation childrenNames. Therefore, when using the .toString() method inherited from the Base expression class, it includes the progress because this method goes through all the expression children names.

Example

const s = carto.expressions;
const animation = s.animation(s.prop('mydate'), 30, s.fade(1, 1));

animation.toString()

// Current result:
"animation($mydate, 30, fade(1, 1), 0.12345)"

// Expected result
"animation($mydate, 30, fade(1, 1))"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant