Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change custom style.css file for examples #1361

Open
elenatorro opened this issue May 29, 2019 · 0 comments
Open

Change custom style.css file for examples #1361

elenatorro opened this issue May 29, 2019 · 0 comments
Labels
priority: low rt-frontend Response Team - Frontend status: discussion Needs more discussion, to start or to be closed / merged type: doc Related to any type of docs: internal, external, examples type: enhancement

Comments

@elenatorro
Copy link
Contributor

Context

For the examples, we're using a custom css for the widgets, legends and other elements. Everytime we release a new version of CARTO VL and update the developer center, the link to that references this style changes.

If we have:

<link href="https://carto.com/developers/carto-vl/v1.2.5/examples/maps/style.css" rel="stylesheet">

And then release a patch version, we'd have:

<link href="https://carto.com/developers/carto-vl/v1.2.6/examples/maps/style.css" rel="stylesheet">

However, the previous link https://carto.com/developers/carto-vl/v1.2.5/examples/maps/style.css won't work anymore.

Therefore, if someone has copy-pasted an example from the developer center, as soon as we release a new version, this won't work.

Although you can change the link to use the current version, we should fix that to avoid confusion. I think we should upload this file to the CDN every time we release a new version, and then change the developer center accordingly to use this new link.

I'd upload to the following path:

https://libs.cartocdn.com/carto-vl/custom/v1.2.3/style.css

@elenatorro elenatorro added type: doc Related to any type of docs: internal, external, examples type: enhancement rt-frontend Response Team - Frontend labels May 29, 2019
@VictorVelarde VictorVelarde added status: discussion Needs more discussion, to start or to be closed / merged priority: low priority: medium and removed priority: low labels Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low rt-frontend Response Team - Frontend status: discussion Needs more discussion, to start or to be closed / merged type: doc Related to any type of docs: internal, external, examples type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants