Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release configuration build fails on Linux #82

Closed
scottrhoyt opened this issue Nov 5, 2016 · 2 comments · Fixed by #83
Closed

Release configuration build fails on Linux #82

scottrhoyt opened this issue Nov 5, 2016 · 2 comments · Fixed by #83
Labels

Comments

@scottrhoyt
Copy link

It appears that Commandant will not successfully build in the release configuration on Linux. This looks to be due to Quick being built and referencing the non-existent (in release) XCTest module. This does not happen on macOS, likely due to the conditional inclusion of Quick in Package.swift. I believe there are some workarounds for Test-only dependencies using SPM, but I am curious as to whether or not Quick is needed on Linux at all if it is not being included on macOS.

Steps to reproduce:

  • Create a new trivial package (e.g. swift-package init --type executable)
  • Add Commandant to Package.swift
  • Build in release configuration using swift build -c release

Expected Results

Package builds without errors.

Actual Results

Package fails to build with linker errors related to Quick referencing XCTest.

@mdiep mdiep added the bug label Nov 5, 2016
@mdiep
Copy link
Member

mdiep commented Nov 5, 2016

I think Quick needs to come out of the Package.swift and needs to be added directly to the CI job like ReactiveSwift does.

Any chance you'd be interested in opening a PR to fix it?

@scottrhoyt
Copy link
Author

Thanks for taking care of that. I was going to open up a PR myself but you beat me to it. Next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants