Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the Cartfile #2627

Open
sirghi opened this issue Oct 26, 2018 · 6 comments
Open

Extend the Cartfile #2627

sirghi opened this issue Oct 26, 2018 · 6 comments

Comments

@sirghi
Copy link

sirghi commented Oct 26, 2018

Carthage is simple. So is this issue trying to be (although the first word in the title gives it away already).

Looking through the issues around here people seem to want to specify dependencies:

  • per scheme
  • per platform

Possible solutions:

  • yaml
  • ogdl
  • prefixes and/or suffixes

While the discussions are long on this subject, I suggest we keep this short and focused, to decide in general whether we want this or not. I'll try to update the above lists if new ideas come up.

@mdiep
Copy link
Member

mdiep commented Oct 27, 2018

I think an extensible format would definitely be helpful. It's not important to focus on specific metadata, but it should be able to support the things you mentioned.

Whatever it is should be compatible with the existing Cartfile. Broad adoption of a format is a big plus. Simplicity is also a big plus.

A good starting place is probably to list any standard formats that are compatible with the existing format. Then show what it'd look like to include additional information.

@KyleLeneau
Copy link

We should make sure that we can support a version of the file format / scheme. Cartfile’s now are only 1 version with no ability to extend and not break new/old versions. I’d like to see a version header be accounted for as well from the start so we can extend this further. The version header I am thinking of is similar to config file based CI systems like Travis or CircleCI version: 0. Maintaining backwards compatibility is important as well with the current files. Would supporting old and a new format be feasible?

@mdiep
Copy link
Member

mdiep commented Oct 29, 2018

I'm not sure that's necessary. The minimum to build should always be the information that's currently in a Cartfile. We may add optional configuration, but the point here is to maintain compatibility with our existing format.

@sirghi
Copy link
Author

sirghi commented Oct 30, 2018

Agree with @mdiep. Versioning would just complicate.

Also, I read people want to specify which schemes are valid to be built in general by Carthage (like for omitting test schemes and the likes). Should I add it to the list?

@mdiep
Copy link
Member

mdiep commented Oct 31, 2018

I don't think we need to worry about building an exhaustive list of extensions that people want. :)

@stale

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants