Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop Fortran interface documentation #116

Open
mefuller opened this issue Oct 1, 2021 · 4 comments
Open

Develop Fortran interface documentation #116

mefuller opened this issue Oct 1, 2021 · 4 comments
Labels
work-in-progress An enhancement that someone is currently working on

Comments

@mefuller
Copy link

mefuller commented Oct 1, 2021

Abstract

Write Fortran documentation in parallel with writing/running/testing some small example programs with emphasis placed on F90+/freeform compatibility

Motivation

There is presently no formal documentation for the Fortran interface

Description

Develop documentation following $FORMAT
Question - can anyone point me to which documentation I should use as a template or where I might find guidance on how to style the documentation? My first impulse is to use the Matlab documentation as it is neither the native C++ nor the widely/heavily-used Python

Alternatives

Do nothing

References

Link to a development branch in my fork of the Cantera repository: https://github.com/mefuller/cantera/tree/fortran-doc

@mefuller mefuller added the work-in-progress An enhancement that someone is currently working on label Oct 1, 2021
@speth
Copy link
Member

speth commented Oct 5, 2021

My hope for revamping and documenting the Cantera Fortran module was to leverage the code-generation approach described in #39. I think @ssun30 is getting close to sharing a version of his implementation of this for the Matlab toolbox (discussed in #102), so I might suggest waiting a bit for that to evolve before jumping into an independent project targeting just the Fortran module.

@ischoegl
Copy link
Member

ischoegl commented Aug 11, 2022

One potential micro-step here would be to create an "Advanced: Fortran tutorial" on Cantera/cantera-website added here that uses the existing demo programs in samples/f77 and samples/f90. Now that libcantera-devel appears to be working as a stand-alone conda package, the initial hurdle to get going should be significantly reduced (see newly added documentation).

@mefuller
Copy link
Author

I'll take a look at it - shouldn't be too hard and it will likely reuse a lot of the C++ tutorial
Certainly the FORTRAN 77 and Fortran 90 demo programs both compile (using make and scons) and just work right out of the box for me (as expected, but still very gratifying)

Anyone know a "good" way to reuse content so that it's linked and not just copy-paste? This is thinking about both the structure of the C++ tutorial and also the code snippets

I'll try to work on this in the coming weeks when I can put together some free time

@ischoegl
Copy link
Member

ischoegl commented Aug 12, 2022

I'll take a look at it - shouldn't be too hard and it will likely reuse a lot of the C++ tutorial

Thanks, @mefuller!

I think that including code snippets the way the C++ tutorial does it is ok for the time being. If we also include the same files in Cantera/cantera’s samples folder, we can start linking to them whenever Cantera 3.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress An enhancement that someone is currently working on
Projects
None yet
Development

No branches or pull requests

3 participants