Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SyntaxError? #64

Closed
Hardtack opened this issue Jan 13, 2018 · 1 comment · Fixed by #67
Closed

SyntaxError? #64

Hardtack opened this issue Jan 13, 2018 · 1 comment · Fixed by #67

Comments

@Hardtack
Copy link
Contributor

Hardtack commented Jan 13, 2018 •
edited
Loading

asyncpgsa.transactionmanager.ConnectionTransactionContextManager raises the SyntaxError in if user try to use it with with ... not async with ...
But it's not syntax error actually. It is right syntax but not right usage!
The error should be the RuntimeError as I think.

https://github.com/CanopyTax/asyncpgsa/blob/master/asyncpgsa/transactionmanager.py#L25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raise RuntimeError when try to use with ... not async with... Hardtack/asyncpgsa
2 participants
@Hardtack @nhumrich