Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The data source connection password is empty #712

Closed
fredalai opened this issue Oct 3, 2024 · 7 comments · Fixed by #806
Closed

The data source connection password is empty #712

fredalai opened this issue Oct 3, 2024 · 7 comments · Fixed by #806
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest hacktoberfest-accepted module/ui UI related

Comments

@fredalai
Copy link
Contributor

fredalai commented Oct 3, 2024

Describe the bug

When viewing the Data Source Settings page for a connected MySQL data source, the password field appears empty.

To Reproduce

Steps to reproduce the behavior:

  1. Connect MySQL data source
  2. Go to the Home / Modeling page
  3. Click "Settings" below the sidebar to view the Data Source Settings
  4. See the password field is empty

Expected behavior

Show password placeholder ************ instead of empty when viewing the Data Source Settings.

Screenshots

截圖 2024-10-03 下午2 47 57

Root cause

The Backend API will not return the password field information, so it will become empty if the front end does not process it.

Solution

  • Display the password placeholder ************ instead of leaving the field empty when viewing the Data Source Settings for the following data sources: ClickHouse, MSSQL, MySQL, Postgres, and Trino.

Note: For Postgres data source, it is currently the correct behavior

@fredalai fredalai added bug Something isn't working good first issue Good for newcomers hacktoberfest module/ui UI related labels Oct 3, 2024
@swarupn17
Copy link

Hello @fredalai !
I think i can do this task please can you assign it to me.
Thanks.

@cubsg
Copy link

cubsg commented Oct 4, 2024

Hi, I've added changes to the MySQLProperties.tsx file. I edited line 76, replacing the password placeholder from "input password" to "************".

@chilijung
Copy link
Member

@swarupn17, it looks like @cubsg has been working on this issue and also submitted a PR. Can you look into other issues that you might be interested in? Thanks!

@ongdisheng
Copy link
Contributor

ongdisheng commented Oct 21, 2024

Hi, it seems like there's an error showing up when clicking on the save button of Data Source Settings page for my connected Postgres data source even though I didn’t modify any settings from the initial setup phase. For reference, I’m using SQLite as the database for my Wren-UI, and the Wren AI version is 0.8.1. Your help is very much appreciated!

Screenshot

Console output

Log output

image

@fredalai
Copy link
Contributor Author

Hi @ongdisheng,

Thanks for catching that issue—it’s a bug.
#800

Thanks,
Freda

@ongdisheng
Copy link
Contributor

Hi @fredalai, I noticed there hasn’t been much progress on the previous PR. Would it be alright if I step in and submit my own PR to help move things forward?

@fredalai
Copy link
Contributor Author

@ongdisheng Yep, sure. reassigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest hacktoberfest-accepted module/ui UI related
Projects
Status: Done
5 participants