-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to redefine default MetaKernel magics with custom ones #172
Conversation
@blink1073, @dsblank, any chance of getting this one reviewed? We're needing it to keep working on our IPdb kernel. Thanks! |
Sorry, just saw this! I'll take a look. |
Thanks! By the way, this is a fantastic project!! Thanks a lot for working on it. |
@ccordoba12 This looks simple and fine; thanks! It would be great to document this someplace, maybe just in the doc string (I know there isn't a lot of docs). Or if not there, how about here: https://github.com/Calysto/metakernel/blob/master/docs/source/installation.rst |
I also approve pending docs, thanks! |
I added a docstring to the Please let me know what you think about it. |
LGTM, thanks Carlos! |
@dsblank, are we ready to cut |
@ccordoba12 Thanks! @blink1073 I think so. Thanks! I'll update the HISTORY with the other changes (and this one) soon. |
Thanks @blink1073 and @dsblank! |
We're building an
ipdb
kernel for Spyder with MetaKernel. For that we defined Pdb commands as magics and some of their names collide with MetaKernel default magics.With this PR users could create magics that are loaded instead of MetaKernel ones with the same name.