Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Partial support for remove in Set #10

Merged
merged 1 commit into from
Nov 16, 2020
Merged

fix: Partial support for remove in Set #10

merged 1 commit into from
Nov 16, 2020

Conversation

antoinelyset
Copy link
Contributor

This adds partial support for remove in Sets (and nested Sets). This is a bit ugly and this won't work for pick. I think this is still useful when we revert insert in Sets.

Calyhre
Calyhre approved these changes Nov 16, 2020
View reviewed changes
Copy link
Owner

@Calyhre Calyhre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix 👍

@Calyhre Calyhre merged commit 5503dcd into Calyhre:master Nov 16, 2020
@Calyhre
Copy link
Owner

Calyhre commented Nov 16, 2020

✅ Published in v1.3.2

@antoinelyset antoinelyset deleted the fix/remove-set branch November 16, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calyhre Calyhre Calyhre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoinelyset @Calyhre