Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covering grammar naming #385

Closed
ajmalanoski opened this issue Mar 23, 2021 · 4 comments · Fixed by #396
Closed

Covering grammar naming #385

ajmalanoski opened this issue Mar 23, 2021 · 4 comments · Fixed by #396
Assignees
Labels
enhancement New feature or request

Comments

@ajmalanoski
Copy link
Collaborator

As it stands, the covering grammar files in data/cg/tsv are just named <lng>.tsv, where <lng> is the three-letter language code. I think the file names should for the CGs should match those used for the data they correspond to, that is, they should phonetic/phonemic status and script name.

@kylebgorman
Copy link
Collaborator

+1

@kylebgorman kylebgorman added the enhancement New feature or request label Mar 23, 2021
@ajmalanoski
Copy link
Collaborator Author

On a related note, the .phones files also do not include the script in their filenames. They probably should, though, right? @kylebgorman

@kylebgorman
Copy link
Collaborator

kylebgorman commented Mar 26, 2021 via email

@ajmalanoski
Copy link
Collaborator Author

Oh duh, very true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants