Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSE tab limit doesn't appear to work #35

Open
ColdHeat opened this issue Nov 1, 2022 · 3 comments
Open

SSE tab limit doesn't appear to work #35

ColdHeat opened this issue Nov 1, 2022 · 3 comments

Comments

@ColdHeat
Copy link
Member

ColdHeat commented Nov 1, 2022

We do not seem to be releasing the SSE connection with each tab. We need to release the connection if we have too many tabs because users will be unable to interact with CTFd if they have too many tabs open.

@ColdHeat
Copy link
Member Author

ColdHeat commented Nov 1, 2022

To reproduce, simply open 6+ tabs of CTFd when using core-beta. The later tabs should not load.

@ColdHeat
Copy link
Member Author

ColdHeat commented Nov 1, 2022

Might need to spend some time investigating this.

@ColdHeat
Copy link
Member Author

ColdHeat commented Nov 2, 2024

It appears that this does happen under http1.1 but not under http2 because the connection limit is increased. The simple solution is to switch to http2 but fixing controller.js would be a better long term fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant