TST: fix test creating invalid CategoricalBlock (pandas-dev#32519)

* TST: fix test creating invalid CategoricalBlock

* ValueError->AssertionError

Author: jbrockmendel

pandas/core/internals/blocks.py

@@ -1739,6 +1739,10 @@ def __init__(self, values, placement, ndim=None):
         values = self._maybe_coerce_values(values)
         super().__init__(values, placement, ndim)
 
+        if self.ndim == 2 and len(self.mgr_locs) != 1:
+            # TODO(2DEA): check unnecessary with 2D EAs
+            raise AssertionError("block.size != values.size")
+
     def _maybe_coerce_values(self, values):
         """
         Unbox to an extension array.

pandas/tests/internals/test_internals.py

@@ -540,6 +540,13 @@ def _compare(old_mgr, new_mgr):
         assert new_mgr.get("g").dtype == np.float64
         assert new_mgr.get("h").dtype == np.float16
 
+    def test_invalid_ea_block(self):
+        with pytest.raises(AssertionError, match="block.size != values.size"):
+            create_mgr("a: category; b: category")
+
+        with pytest.raises(AssertionError, match="block.size != values.size"):
+            create_mgr("a: category2; b: category2")
+
     def test_interleave(self):
 
         # self
@@ -552,14 +559,10 @@ def test_interleave(self):
         # will be converted according the actual dtype of the underlying
         mgr = create_mgr("a: category")
         assert mgr.as_array().dtype == "i8"
-        mgr = create_mgr("a: category; b: category")
-        assert mgr.as_array().dtype == "i8"
         mgr = create_mgr("a: category; b: category2")
         assert mgr.as_array().dtype == "object"
         mgr = create_mgr("a: category2")
         assert mgr.as_array().dtype == "object"
-        mgr = create_mgr("a: category2; b: category2")
-        assert mgr.as_array().dtype == "object"
 
         # combinations
         mgr = create_mgr("a: f8")
@@ -702,7 +705,7 @@ def test_equals(self):
             "a:i8;b:f8",  # basic case
             "a:i8;b:f8;c:c8;d:b",  # many types
             "a:i8;e:dt;f:td;g:string",  # more types
-            "a:i8;b:category;c:category2;d:category2",  # categories
+            "a:i8;b:category;c:category2",  # categories
             "c:sparse;d:sparse_na;b:f8",  # sparse
         ],
     )