Skip to content

Conversation

@lmondada
Copy link
Contributor

@lmondada lmondada commented May 27, 2025

This PR is ready to be reviewed/merged if we choose to go down this route.

See discussion #2253

@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 77.83019% with 47 lines in your changes missing coverage. Please review.

Project coverage is 81.98%. Comparing base (2ac4181) to head (6b95519).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
hugr-core/src/hugr/persistent/serialize.rs 76.51% 18 Missing and 17 partials ⚠️
...gr-core/src/hugr/patch/simple_replace/serialize.rs 73.33% 3 Missing and 5 partials ⚠️
hugr-core/src/hugr/serialize/serde_seed.rs 87.87% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2258      +/-   ##
==========================================
- Coverage   82.00%   81.98%   -0.02%     
==========================================
  Files         237      240       +3     
  Lines       42778    42990     +212     
  Branches    38690    38902     +212     
==========================================
+ Hits        35079    35247     +168     
- Misses       5706     5727      +21     
- Partials     1993     2016      +23     
Flag Coverage Δ
python 85.34% <ø> (ø)
rust 81.63% <77.83%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lmondada
Copy link
Contributor Author

lmondada commented Jun 3, 2025

Superseded by #2300

@lmondada lmondada closed this Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants