feat: Reimplement insert_hugr using only HugrView
#2174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2174 +/- ##
=======================================
Coverage 82.09% 82.10%
=======================================
Files 227 227
Lines 39801 39786 -15
Branches 35900 35885 -15
=======================================
- Hits 32676 32666 -10
+ Misses 5303 5299 -4
+ Partials 1822 1821 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Oh, I should also have done Edit: Done! |
lmondada
reviewed
May 8, 2025
hugr-core/src/hugr/hugrmut.rs
Outdated
| other: &H, | ||
| ) -> InsertionResult<H::Node, Self::Node> { | ||
| let (inserted_entrypoint, node_map) = insert_hugr_internal(self, root, other); | ||
| let res = insert_hugr_internal(self, root, &other); |
Contributor
There was a problem hiding this comment.
Suggested change
| let res = insert_hugr_internal(self, root, &other); | |
| let res = insert_hugr_internal(self, root, other); |
lmondada
reviewed
May 8, 2025
Contributor
lmondada
left a comment
lmondada
left a comment
There was a problem hiding this comment.
LGTM, thanks! I'll wait for the impl for insert_subgraph
lmondada
approved these changes
May 8, 2025
lmondada
approved these changes
May 8, 2025
This was referenced May 8, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes another use of
HugrInternals::portgraph