Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trill notes are not parsed as such from match v0 #286

Closed
sildater opened this issue Jun 20, 2023 · 4 comments · Fixed by #332
Closed

Trill notes are not parsed as such from match v0 #286

sildater opened this issue Jun 20, 2023 · 4 comments · Fixed by #332
Assignees
Labels
bug Something isn't working

Comments

@sildater
Copy link
Member

In the example file pianodata\match\beethoven_op002_no2_mv1.match there are some trill markings. They do not show up in the alignment and in fact are probably not parsed correctly in line 199 of importmatch.py. A reason for the bug could be the regex for the line as defined in line 867 of matchlines_v0.py:

ornament_pattern: re.Pattern = re.compile(r"trill\((?P<Anchor>[^\)]*)\)-")

I think this is missing some regex for the performed note after the dash.

@sildater sildater added the bug Something isn't working label Jun 20, 2023
@huispaty huispaty self-assigned this Aug 8, 2023
@huispaty
Copy link
Collaborator

huispaty commented Aug 8, 2023

Do you have a testfile for this version? (The one in the repo is of version 5.0)

@sildater
Copy link
Member Author

sildater commented Aug 8, 2023

confusingly, v5.0 in match is v0 in partitura (v0 = v0.n.0 for n in 1-5), v1 is only used for v1.0.0

@manoskary
Copy link
Member

Is this linked issue to any PR? Should it be scheduled for Release 1.3.2 ?

@huispaty
Copy link
Collaborator

No, it's neither linked to any existing PR nor scheduled for Release 1.3.2 (same for issue #267). Both will be handled in the next release.

@sildater sildater linked a pull request Oct 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants