Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic blackening of code might be broken #269

Closed
sildater opened this issue Jun 13, 2023 · 5 comments
Closed

automatic blackening of code might be broken #269

sildater opened this issue Jun 13, 2023 · 5 comments

Comments

@sildater
Copy link
Member

release 1.3.0 does not seem to be blackened. e.g. the note_features.py module has very wide lines and horizontal lists.

@sildater
Copy link
Member Author

and also doc string length seems to be unaffected by blacken, so we need to check this manually.

@manoskary
Copy link
Member

I just realized why it did not work....
I called the workflow to run for PR or push on master not main

@manoskary
Copy link
Member

However, I will change the workflow to run only after every push to develop instead, so that the blacken code is first previewed and stays on develop.

@sildater
Copy link
Member Author

Ah, yes that's a good idea!

@manoskary
Copy link
Member

The blacken now works on develop and submits a new commit with the blacken code which gains authorship from the person pushing to develop. I will leave this issue open if there are any other remarks about the blacken process, otherwise feel free to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants