-
Notifications
You must be signed in to change notification settings - Fork 4
update PD_CALIBRATION
#134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Question: Does this mean that if neither of these is given a value, they take on the value of eg: The intent is that Would ? If the calibration were determined by some other method than a reference diffraction pattern, then I don't want to have a value for ref_diff_id. But, then again, a diffraction pattern to which a calibration is applied, then becomes a secondary reference pattern, so... |
|
What's above is the wrong way of doing it. It should work much in the way It needs:
We can find the instrument and detectors from This is basically formalising what it already was. . The next question is to whether the key should be changed.
|
EDIT: Lots of things have changed. Jump to the bottom for the current version.
.
Will close #133. Also applicable to #132.
This PR enhances
PD_CALIBRATIONby providing a category key based on the diffractogram_id to which the calibration applies, and a dataitem to record the diffractogram_id of the reference diffraction pattern from which the calibration was made.