Deprecate calibration categories #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The failed check is due to the category deprecations. The checks can't find the replacement category. |
Collaborator
|
The The information about category deprecation and replaced can be recorded in the description as a human-readable text (as is currently done). |
Collaborator
Author
|
Ah. I must have misunderstood James' answer previously. Will change. |
Collaborator
Author
|
I think |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally talked about in #53 and implemented in #89, #91, #92, and #93
The new categories
PD_CALIB_DETECTED_INTENSITYPD_CALIB_INCIDENT_INTENSITYPD_CALIB_WAVELENGTHPD_CALIB_XCOORDPD_QPA_INTERNAL_STDtake up the functionality previously facilitated by
PD_CALIBPD_CALIB_OFFSETPD_CALIB_STDThis PR is to deprecate redundant data items and categories.
.
I'm not deprecating
PD_CALIBRATIONyet, as I need to convince myself how I can calibrate a (for instance) energy-sensitive detector based on detector_id to energy (or position, or 2th or whatever...)