-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty repeater is not empty if containing a file field #721
Comments
Thank you for reporting! |
Correct. Worked with 2.2.1. Updated to 2.2.2.1 and it "broke". After we updated the client kept getting empty boxes (due for us checking for ! empty meta) and everytime they updated a post the empty boxes appeared on the post. Tested on 2.2.2 and @dev and the same problem appears. So currently rolled back to 2.2.1. |
I'm having the same issue here. Does anyone have a workaround instead of having to roll back? |
No solutions that I'm aware of at the moment. |
I will go through the commits the upcoming week one by one and report on which commit this bug appears. If it's simple enough I will suggest a pull request. |
Did you ever make any headway with this one @phh ? |
@tw2113 Not yet :( Will test if the new update solves this problem or not. |
As of 2.2.3.1 the issue is still occurring. |
A git bisect could provide a definitive answer for what commit caused the breakage. |
Finally! Seems like dba5776 broke it. |
Ick, anything revolving around '0' is an instant headache :) |
True. Is there a reason for the file type to always have a value of '0'? How is normal file types saved? I guess these also have this '0' value? |
That one I'm going to have to defer to @jtsternberg |
Anything new on this? I am finding that it is still an issue. Making some things look unseemly on a project I'm working on. |
Thanks! |
Expected Behavior:
The meta value of the repeater group to be empty
Actual Behavior:
Instead returning one entry in the array with a file_id field containing
0
Steps to reproduce (I have confirmed I can reproduce this issue on the trunk branch):
CMB2 Field Registration Code:
The text was updated successfully, but these errors were encountered: