Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo in population size of first regime #229

Open
vinaym815 opened this issue Sep 13, 2021 · 2 comments
Open

Possible typo in population size of first regime #229

vinaym815 opened this issue Sep 13, 2021 · 2 comments
Assignees

Comments

@vinaym815
Copy link

vinaym815 commented Sep 13, 2021

double ltmp = pow(0.5*(_lambda_l/_lambda_def),u);

Should not the value sampled from uniform distribution be squared as suggested in:
https://hal.inria.fr/inria-00382093/document
https://hal.inria.fr/hal-00818596v1/document

Also it might be desirable to change the sigma expression to the one proposed in second paper.
sigma expression of first publication:
133079718-ff95beca-f90b-42ad-a77b-df54d82b2c05

sigma expression of the second publication:
sigma2

@beniz
Copy link
Collaborator

beniz commented Sep 13, 2021

image

Hi @vinaym815 good catch, possibly, let's see whether @nikohansen can confirm ?

@beniz beniz self-assigned this Sep 13, 2021
@nikohansen
Copy link
Collaborator

Yes, I agree with both, 2 -> default initial sigma and the uniform random number should be squared first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants