Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boundary_transformation() functions not prefixed with cmaes_ #5

Open
sherm1 opened this issue Oct 23, 2014 · 2 comments
Open

boundary_transformation() functions not prefixed with cmaes_ #5

sherm1 opened this issue Oct 23, 2014 · 2 comments

Comments

@sherm1
Copy link
Contributor

sherm1 commented Oct 23, 2014

Hi, Niko. While incorporating cma-es into Simbody, we noticed some external functions boundary_transformation() etc. that don't have the usual cmaes_ prefix so would potentially cause link-time conflicts for our users. @chrisdembia removed those files from our port for now, but I would like to be able to include the whole package unchanged to facilitate later updating, and in case someone wants to take advantage of those functions later. Please prefix all the extern functions if possible.

Sherm

@nikohansen
Copy link
Contributor

I am somewhat hesitating to prefix the boundary functions with cmaes_, because they are entirely unrelated to the optimization method used. I see the point though to have the module source explicitly given to reduce the possibility of name clashes.

@sherm1
Copy link
Contributor Author

sherm1 commented Dec 10, 2014

I see your point. And these are all prefixed by boundary_ already -- my only worry is that that prefix is a little too generic so someone else might reasonably use the same one. But that's a hypothetical concern at this point. We are not linking in those functions at the moment so we don't have a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants