Skip to content

Commit 0f13805

Browse files
committed
replace black with ruff format
1 parent a4facfb commit 0f13805

File tree

7 files changed

+56
-128
lines changed

7 files changed

+56
-128
lines changed

.github/scripts/update_manifest.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def update_manifest():
1616

1717
version_striped = version.replace("v", "")
1818

19-
print(f"Version number being inserted: {str(version_striped)}")
19+
print(f"Version number being inserted: {version_striped!s}")
2020

2121
print("Opening file...")
2222

@@ -30,9 +30,7 @@ def update_manifest():
3030

3131
print("Saving file...")
3232

33-
with open(
34-
f"{os.getcwd()}/custom_components/qss/manifest.json", "w"
35-
) as manifestfile:
33+
with open(f"{os.getcwd()}/custom_components/qss/manifest.json", "w") as manifestfile:
3634
manifestfile.write(json.dumps(manifest, indent=4, sort_keys=True))
3735

3836
print("Done!")

.pre-commit-config.yaml

+11-6
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,19 @@ repos:
1717
args: [--mapping, '2', --sequence, '4', --offset, '2', --width, '120', --implicit_start]
1818
- repo: local
1919
hooks:
20-
- id: black
21-
name: black
22-
entry: poetry run black
20+
- id: codespell
21+
name: codespell
22+
entry: poetry run codespell --write-changes --skip="./*"
23+
language: system
24+
pass_filenames: false
25+
always_run: true
26+
- id: ruff format
27+
name: ruff format
28+
entry: poetry run ruff format
2329
language: system
2430
types: [python]
25-
require_serial: true
26-
- id: ruff
27-
name: ruff
31+
- id: ruff lint
32+
name: ruff lint
2833
entry: poetry run ruff
2934
language: system
3035
types: [python]

custom_components/qss/__init__.py

+6-13
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,7 @@ async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool:
7979
auth_y_key = conf.get(CONF_AUTH).get(CONF_AUTH_Y_KEY)
8080
db_auth = (auth_kid, auth_d_key, auth_x_key, auth_y_key)
8181

82-
instance = QuestDB(
83-
hass=hass, host=db_host, port=db_port, entity_filter=entity_filter, auth=db_auth
84-
)
82+
instance = QuestDB(hass=hass, host=db_host, port=db_port, entity_filter=entity_filter, auth=db_auth)
8583
instance.async_initialize()
8684
instance.start()
8785

@@ -91,7 +89,7 @@ async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool:
9189
class QuestDB(threading.Thread): # pylint: disable = R0902
9290
"""A threaded qss class."""
9391

94-
def __init__(
92+
def __init__( # noqa: PLR0913
9593
self,
9694
hass: HomeAssistant,
9795
host: str,
@@ -118,7 +116,6 @@ def async_initialize(self):
118116

119117
def run(self):
120118
"""Run qss and insert data."""
121-
122119
shutdown_task = object()
123120
hass_started = concurrent.futures.Future()
124121

@@ -127,7 +124,7 @@ def register():
127124
"""Register qss to Home Assistant."""
128125
self.qss_ready.set_result(True)
129126

130-
def shutdown(event: Event): # pylint: disable = W0613
127+
def shutdown(event: Event): # noqa: ARG001
131128
"""Shut down the qss."""
132129
if not hass_started.done():
133130
hass_started.set_result(shutdown_task)
@@ -141,13 +138,11 @@ def shutdown(event: Event): # pylint: disable = W0613
141138
else:
142139

143140
@callback
144-
def notify_hass_started(event: Event): # pylint: disable = W0613
141+
def notify_hass_started(event: Event): # noqa: ARG001
145142
"""Notify that hass has started."""
146143
hass_started.set_result(None)
147144

148-
self.hass.bus.async_listen_once(
149-
EVENT_HOMEASSISTANT_START, notify_hass_started
150-
)
145+
self.hass.bus.async_listen_once(EVENT_HOMEASSISTANT_START, notify_hass_started)
151146

152147
self.hass.add_job(register)
153148
result = hass_started.result()
@@ -158,9 +153,7 @@ def notify_hass_started(event: Event): # pylint: disable = W0613
158153
while True:
159154
event = get_event_from_queue(self.queue)
160155
finish_task_if_empty_event(event, self.queue)
161-
insert_event_data_into_questdb(
162-
self.host, self.port, self.auth, event, self.queue
163-
)
156+
insert_event_data_into_questdb(self.host, self.port, self.auth, event, self.queue)
164157

165158
@callback
166159
def event_listener(self, event: Event):

custom_components/qss/event_handling.py

+2-9
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,11 @@
66
from homeassistant.core import Event
77

88

9-
def put_event_to_queue(
10-
event: Event, entity_filter: Callable[[str], bool], queue: Queue
11-
) -> None:
9+
def put_event_to_queue(event: Event, entity_filter: Callable[[str], bool], queue: Queue) -> None:
1210
"""Get events with new states and put them in the process queue."""
1311
entity_id = event.data.get(ATTR_ENTITY_ID)
1412
state = event.data.get("new_state")
15-
if all([
16-
entity_id,
17-
state,
18-
state.state != STATE_UNKNOWN,
19-
entity_filter(entity_id)
20-
]):
13+
if all([entity_id, state, state.state != STATE_UNKNOWN, entity_filter(entity_id)]):
2114
queue.put(event)
2215

2316

custom_components/qss/io.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,7 @@ def _retry_data_insertion(host: str, port: int, auth: tuple, event: Event) -> No
6969
_insert_row(host, port, auth, event)
7070

7171

72-
def insert_event_data_into_questdb(
73-
host: str, port: int, auth: tuple, event: Event, queue: Queue
74-
) -> None:
75-
"""Inserting given event data into QuestDB."""
72+
def insert_event_data_into_questdb(host: str, port: int, auth: tuple, event: Event, queue: Queue) -> None:
73+
"""Insert given event data into QuestDB."""
7674
_retry_data_insertion(host, port, auth, event)
7775
queue.task_done()

poetry.lock

+12-87
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

+21-5
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ tenacity = "^8.0.0"
1616
[tool.poetry.dev-dependencies]
1717
homeassistant = "^2023.6"
1818
pre-commit = "^2.21.0"
19-
black = "^22.12.0"
19+
codespell = "^2.0.0"
2020
ruff = "^0.1.6"
2121

2222

@@ -27,15 +27,31 @@ build-backend = "poetry.core.masonry.api"
2727

2828
[tool.ruff]
2929
select = [
30+
# Ruff specific
31+
"RUF",
32+
# Pylint
33+
"PL",
3034
# Pyflakes
3135
"F",
36+
# pep8-naming
37+
"N",
3238
# Pycodestyle
3339
"E",
3440
"W",
41+
"D",
42+
# flake8-2020
3543
"YTT",
44+
# flake8-async
45+
"ASYNC",
46+
# flake8-bugbear
47+
"B",
48+
# flake8-unused-arguments
49+
"ARG",
50+
# flake8-commas
51+
"COM",
3652
# Isort
37-
"I001",
38-
"I002"
53+
"I"
3954
]
40-
line-length = 88
41-
fix = false
55+
extend-ignore = ["PLR2004", "D203", "D213", "COM812"]
56+
line-length = 120
57+
fix = true

0 commit comments

Comments
 (0)