Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yanglint tests fail for release build #2264

Closed
labuwx opened this issue Jul 1, 2024 · 1 comment
Closed

yanglint tests fail for release build #2264

labuwx opened this issue Jul 1, 2024 · 1 comment
Labels
is:bug Bug description. status:completed From the developer perspective, the issue was solved (bug fixed, question answered,...)

Comments

@labuwx
Copy link

labuwx commented Jul 1, 2024

Hi,

Some tests in yanglint_interactive fail when are run on a release build.
The tests in tests/yanglint/interactive/debug.test are only meant to be run on a debug build but the yanglint_debug check in tests/yanglint/interactive/ly.tcl does not do its job since commit 34e2a55.
yanglint_debug looks for --debug= in the output of yanglint -h. However since 34e2a55, that string appears in release builds too.
@michalvasko
Copy link
Member

Right, the test seems useless anyway, removed.

@michalvasko michalvasko added is:bug Bug description. status:completed From the developer perspective, the issue was solved (bug fixed, question answered,...) labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is:bug Bug description. status:completed From the developer perspective, the issue was solved (bug fixed, question answered,...)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@labuwx @michalvasko