Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an indication that a karton task originated from MWDB #432

Open
1 of 4 tasks
ITAYC0HEN opened this issue Aug 3, 2021 · 1 comment
Open
1 of 4 tasks

Add an indication that a karton task originated from MWDB #432

ITAYC0HEN opened this issue Aug 3, 2021 · 1 comment
Labels
type:improvement Small improvement of existing feature zone:backend MWDB backend core related tasks

Comments

@ITAYC0HEN
Copy link
Contributor

Feature Category

  • Correctness
  • User Interface / User Experience
  • Performance
  • Other (please explain)

Describe the problem

Some kartons might want to know whether a karton task is originated from MWDB or not. This especially relevant for designs where samples arrive at Karton before they arrive in MWDB.

For example:
In order to prevent resubmitting of files again and again to sandboxes, we want our sandbox-dispatcher to check if the file was already analyzed, and if it does, don't submit it. It already works perfectly.
But we do have an issue, because we do want the file to be re-submitted to the sandboxes if a MWDB user pressed the REANALYZED karton button in MWDB. In this case, we want to force the system to resubmit the file to the sandboxes, even though it was analyzed before.

To do this, we need to find a way for sandbox-dispatcher to know if the file was sent by the integrated Karton in MWDB. This way we can check if the file came to the karton system from MWDB then submit it to sandboxes.

Describe the solution you'd like

Add some kind of persistence payload to the outgoing task, that indicates that the task was originated by mwdb.

Describe alternatives you've considered

  1. More generic approach — add to karton a field named "original_source""original_origin""root_origin" or something like this, that will be assigned once, with the karton.identity of the karton that first produced this task.
  2. Implement an API in karton that can be used like this get_origin_by_root_uid(task.root_uid) or something like root_ui.identity==karton.mwdb
@psrok1 psrok1 added type:improvement Small improvement of existing feature zone:backend MWDB backend core related tasks labels Aug 24, 2021
@ITAYC0HEN
Copy link
Contributor Author

@psrok1 welcome back! What do you think about the ideas and offered alternatives?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:improvement Small improvement of existing feature zone:backend MWDB backend core related tasks
Projects
None yet
Development

No branches or pull requests

2 participants