Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install python-magic package on setup #16

Merged
merged 1 commit into from
May 25, 2017
Merged

Install python-magic package on setup #16

merged 1 commit into from
May 25, 2017

Conversation

ilyaglow
Copy link

@ilyaglow ilyaglow commented May 25, 2017

Hey guys,

I noticed that installing thehive4py from PyPI doesn't let you use the client, because python-magic package is missing in the setup.py. The error message I receive is:

...
    from thehive4py.api import TheHiveApi
  File "/home/ilya/thehive-env/lib/python3.5/site-packages/thehive4py/api.py", line 8, in <module>
    import magic
ImportError: No module named 'magic'

Same for python 2.7:

...
    from thehive4py.api import TheHiveApi
  File "/home/ilya/.local/share/virtualenvs/thehive-LPUGdsMD/local/lib/python2.7/site-packages/thehive4py/api.py", line 8, in <module>
    import magic
ImportError: No module named magic

This PR should resolve the issue.

@nadouani
Copy link
Contributor

Well, I think we misunderstood the difference between setup.py and requirements.txt. I'll merge this PR, Thanks

For reference: https://caremad.io/posts/2013/07/setup-vs-requirement/

@nadouani nadouani merged commit 0c1fe1c into TheHive-Project:develop May 25, 2017
@nadouani
Copy link
Contributor

This will be be included on the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants