Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certificate verify option not included in create_case_task #27

Closed
armngar opened this issue Jul 28, 2017 · 3 comments
Closed

certificate verify option not included in create_case_task #27

armngar opened this issue Jul 28, 2017 · 3 comments
Milestone

Comments

@armngar
Copy link

armngar commented Jul 28, 2017

Request Type

Bug

Work Environment

Question Answer
OS version (server) Docker
OS version (client) Ubuntu
TheHive4py version / git hash 512af3a

Problem Description

In line 67 of api.py, the option to specify certificate validation isn't included.

Steps to Reproduce

Attempt to disable certificate validation and then call create_case_task

Possible Solutions

return requests.post(req, headers={'Content-Type': 'application/json'}, data=data, proxies=self.proxies, auth=self.auth, verify=self.cert,)

Complementary information

N/A

@armngar
Copy link
Author

armngar commented Jul 28, 2017

I see another similar bug on line 87 as well

@billmurrin
Copy link

FYI, I added a pull request to address this issue.
#28

@nadouani
Copy link
Contributor

Yes this has been fixed by #28

Thanks

@nadouani nadouani added this to the 1.3.0 milestone Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants