fix: issue warnings instead of errors when trying to check the header of hap files and issue error when output of transform is not provided to simphenotype #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were issuing errors in the .hap reader before but it turns out that there are perfectly legitimate reasons for the header to lack an extra field. For example, if a hap file only contains haplotypes (and not repeats) and we try to provide the hap file to
simphenotype
, which expects both haplotypes and repeats to be declared in the header.This PR also switches on a message in
simphenotype
that would warn when the output oftransform
is not properly passed tosimphenotype
. Incidentally, I do this all the time 😅 It also converts the warning to an error.