Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Not having 23 chromosomes in genotype blocks when 23 chromosomes listed in centromere file resulted in Value Error #234

Merged
merged 2 commits into from
Jan 8, 2024
Merged

fix: Not having 23 chromosomes in genotype blocks when 23 chromosomes listed in centromere file resulted in Value Error #234

merged 2 commits into from
Jan 8, 2024

Conversation

mlamkin7
Copy link
Collaborator

@mlamkin7 mlamkin7 commented Jan 7, 2024

Added skip so we can generate karyograms with less than 23 chromosomes even when 23 are listed in the centromere file.

@mlamkin7 mlamkin7 requested a review from aryarm January 7, 2024 23:48
@mlamkin7 mlamkin7 linked an issue Jan 7, 2024 that may be closed by this pull request
Error when using centromeres file for karyogram #233
Closed
@mlamkin7 mlamkin7 changed the title Fix: Not having 23 chromsomes in genotype blocks when 23 chromosomes listed in centromere file resulted in Value Error. fix: Not having 23 chromsomes in genotype blocks when 23 chromosomes listed in centromere file resulted in Value Error. Jan 7, 2024
aryarm
aryarm reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@aryarm aryarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlamkin7 , it seems like most of the changes are just reformatting?

the biggest change is that there's just a new test, right?

aryarm
aryarm approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@aryarm aryarm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I see now that this is the main change

looks good!

to resolve the failing readthedocs build, you probably just need to click "Update branch" to bring in the latest commits from main

@aryarm aryarm changed the title fix: Not having 23 chromsomes in genotype blocks when 23 chromosomes listed in centromere file resulted in Value Error. fix: Not having 23 chromosomes in genotype blocks when 23 chromosomes listed in centromere file resulted in Value Error Jan 8, 2024
@mlamkin7 mlamkin7 merged commit ef36798 into main Jan 8, 2024
9 checks passed
@mlamkin7 mlamkin7 deleted the fix/karyogram_chrom_list branch January 8, 2024 17:04
@github-actions github-actions bot mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryarm aryarm aryarm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when using centromeres file for karyogram
2 participants
@mlamkin7 @aryarm