fix: explicitly ignore repeats in the ld command
#218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A future release of haptools will add support for repeats in the
ldcommand. Unfortunately, that will very likely require us to make breaking changes to theldcommand to make the interface flexible enough for users to be able to specify all of the possible ways to compute LD with a repeat or a set of repeats. So for now, we will just delay the breaking changes and explicitly ignore repeats in the meantime.Users who are interested in computing LD with repeats may use the haptools API or PLINK2's
--ld dosagefeature until we add support.