feat: updated .vcf.gz output in simgenotype
#150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryarm
changed the title
.vcf.gz output in simgenotype
aryarm
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
looks great!
in the future, I think it might be helpful to have some way to choose the file extension, so we can support bcf or plain-old vcf, but not a super huge concern right now
btw, I updated the title to include a colon after the "feat" so that we could get pass the title github action check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #148
Updated VCF output to output as a .gz file