Skip to content

Add missing fields in File Info and Device Info. #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ysx3ehaor opened this issue Dec 27, 2024 · 3 comments
Open

Add missing fields in File Info and Device Info. #155

ysx3ehaor opened this issue Dec 27, 2024 · 3 comments
Assignees

Comments

@ysx3ehaor
Copy link

ysx3ehaor commented Dec 27, 2024

Please consider adding the following fields:

  • File Info: FileVersion, FileRevision
  • Device Info: RevisionNumber

[FileInfo]
...
FileVersion=1
FileRevision=0
...

[DeviceInfo]
...
RevisionNumber=00
...

Some software requires these fields to display information when importing EDS files. Currently, I have to manually edit the EDS file text.

Thank you!

@nimrof
Copy link
Collaborator

nimrof commented Dec 28, 2024

Please consider adding the following fields:
* File Info: FileVersion, FileRevision

Will look into it

* Device Info: RevisionNumber

Looking at #154 that might be fixed by linking it with the value of identity object subindex 03.
Would that work for you?
Might add a textbox that indicates where the values is coming from and some tooltip

@nimrof nimrof self-assigned this Dec 28, 2024
@trojanobelix
Copy link
Collaborator

What build? Can not reproduce. Use latest build!

@henri62
Copy link

henri62 commented Mar 21, 2025

I can confirm that "FileVersion" does work in the v4.2.3 version of the editor.

But there is no field to fill-in the FileRevision. Thas number is always 1.
I would suggest to add an additional textbox entry in the TAB "Device Info" / File Info section below the File version.

Also the field [DeviceInfo] -> RevisionNumber is missing in the editor, in the generated EDS its always 0.
I would suggest to add a field it just below the Product ID.

Another issue I saw is that the "File Info" and "Product ID" fields are UNSIGNED8 types and you can now fill in anything in that field.
During save or export it is not checked if its a non-number (hex numbers should be allowed by the way). The result is a non-compliant EDS file.

The CiA306 says this about the type of fields:

FileVersion shall indicate the actual file version (Unsigned8),
FileRevision shall indicate the actual file revision (Unsigned8),
....
VendorNumber shall provide the unique vendor ID according to identity object sub-index 01h (Unsigned32)
ProductNumber shall provide the product code according to identity object sub-index 02h (Unsigned32)
RevisionNumber shall provide the product revision number according to identity object subindex 03h (Unsigned32)

It would be very nice if these fields are checked during save or export if its really a valid number.

Regarding the linking of the above fields with the OD entries; to my opinion the Device Info and File Info section sould be autoritatitive and the Object dictionary should follow that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants