Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programs in the configuration repo #1

Open
ccarouge opened this issue Apr 16, 2024 · 1 comment
Open

Programs in the configuration repo #1

ccarouge opened this issue Apr 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ccarouge
Copy link
Member

I believe we decided to have a first implementation that requires as little change as possible from the original scripts. I'm putting this here so we have a record and we can refer to it later on if required.

I would prefer if configurations have no program files in the repository and only contain the files that define the simulation itself. So here we might only need run_TRENDY.sh. It's possible run_cable.sh should be kept in as well or maybe not.

@ccarouge ccarouge added the enhancement New feature or request label Apr 16, 2024
@Whyborn
Copy link
Collaborator

Whyborn commented Apr 16, 2024

I think the issue is that some of the program files relate specifically to this configuration, so I don't think there's a good reason to keep them with the CABLE code because they are not part of the CABLE code itself. We can address this with the planned CABLEtools/CABLEscripts repository, to store the auxiliary python scripts. The problem is see in that case is that we then ask the users to go find another repository and pull select files from there.

There's the further issue of if the scripts get modified in future. Of course it's an option to include a reference to a specific commit of the CABLEtools repository, but that's another thin layer of obscurity which new users need to work through.

I prefer the approach of having the self-contained configuration repositories that just run out of the box, but we can discuss further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants