You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Photosynthesis is calculated in cable_canopy in CABLE-POP but also in cable_optimise_JV_module. The routines that solve the quadratic (implicit gm) or cubic (explicit gm) equations exists in both modules (called fAn_c3, etc.). This is because the input in cable_canopy is double precisision while it is single precision in cable_optimise_JV_module.
I propose to remove redundant code by putting these routines in a separate module that deals with single/double precision (using interface with module procedure).
I would further try to get the photosynthesis code in both modeuls as close as possible so that the least changes have to be done during further developments.
There are also two routines (golden and rtbis) that come from Numerical Recipes. I propose to also take them out of the module and put them into the utils directory (which has only minpack until now). They can have individual modules (cbl_golden, cbl_rtbis) or one module like cbl_numerical_recipes.
The text was updated successfully, but these errors were encountered:
Photosynthesis is calculated in
cable_canopy
in CABLE-POP but also incable_optimise_JV_module
. The routines that solve the quadratic (implicit gm) or cubic (explicit gm) equations exists in both modules (calledfAn_c3
, etc.). This is because the input incable_canopy
is double precisision while it is single precision incable_optimise_JV_module
.I propose to remove redundant code by putting these routines in a separate module that deals with single/double precision (using interface with module procedure).
I would further try to get the photosynthesis code in both modeuls as close as possible so that the least changes have to be done during further developments.
There are also two routines (
golden
andrtbis
) that come from Numerical Recipes. I propose to also take them out of the module and put them into the utils directory (which has only minpack until now). They can have individual modules (cbl_golden
,cbl_rtbis
) or one module likecbl_numerical_recipes
.The text was updated successfully, but these errors were encountered: