Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mailmap support #366

Merged
merged 32 commits into from
Mar 29, 2022
Merged

mailmap support #366

merged 32 commits into from
Mar 29, 2022

Conversation

Byron
Copy link
Member

@Byron Byron commented Mar 26, 2022 •
edited
Loading

Take git2's implementation for an idea on how the API could look like.

  • parsing
  • data structure for lookup (see mailmap for prior work
    • make sure this is fast for 400+ entries like in the linux kernel
  • docs
  • gix mailmap verify - check for errors and print them if one comes up.
  • mailmap lookup/creation according to rules in git-repository
  • gix repo mailmap entries - list all entries and inform about errors, too
  • use mailmap in gix t h if present, instead of using own algorithm.

@Byron Byron mentioned this pull request Mar 26, 2022
Closed
11 tasks
@Byron Byron changed the title mailmap mailmap support Mar 26, 2022
Byron added 28 commits March 26, 2022 08:32
@Byron
empty git-mailmap crate (#366)
a30a5da
@Byron
Release git-mailmap v0.0.0
c43af35
@Byron
the first empty test (#366)
fc47c49
@Byron
refactor
3e78ff5
@Byron
basic testing of common cases for mailmap (#366)
903c526 
error handling is tested only by integration-level test,
and more error handling tests would have to be added.
@Byron
thanks clippy
9449bc7
@Byron
fix serde support (#366)
2fb4310
@Byron
high-level parsing to deal with allowed mailmap lines (#366)
f458817
@Byron
all tests (so far) green (#366)
67a2050
@Byron
quickfix for unintentionally using 'unicode' feature of bytecode (#366)
fb5593a 
It pulls in a regex engine or parts of it, and for now we avoid that.
@Byron
cleanup bstr usage to not accidentally pull in unicode (#366)
8ff53af
@Byron
Commit to using 'unicode' feature of bstr as git-object wants it too
471fa62
@Byron
Add typical malmap example (#366)
b67b0f9
@Byron
sketch of mailmap snapshot for lookups (#366)
d71d067
@Byron
feat: Time::default() (#366)
77ef2cb
@Byron
add fixture_bytes to test tools
85e3820
@Byron
sketch Snapshot API to implement map building and signature resolut…
1890db7 
…ion (#366)
@Byron
actual lookup and tests, all seems to be working (#366)
8116664
@Byron
thanks clippy
1038dab
@Byron
Add method to return borrowed values for new name/email (#366)
87fb932 
That way, one _can_ optimize for performance and be zero copy
after the mail map has been created.
Maybe this can be useful in the estimate-hours program.
@Byron
Another test to validate correct merging and overwriting (#366)
deaeb7d
@Byron
add all docs (#366)
1c768a5
@Byron
fix email-only case (#366)
e31754d
@Byron
verify universal line-endings are supported (#366)
f498dac
@Byron
Merge branch 'main' into mailmap
b2df941
@Byron
feat: unstable mailmap module (#366)
e3bc1b4
@Byron
feat: gix mailmap verify command (#366)
384ed66
@Byron
gix mailmap verify can now detect collisions (#366)
f89fe2f
Byron added a commit that referenced this pull request Mar 29, 2022
@Byron
update mailmap status (#366)
b53da03
Byron added a commit that referenced this pull request Mar 29, 2022
@Byron
feat: ein tool estimate-hours now supports mailmaps (#366)
def80df
@Byron Byron merged commit d2388d8 into main Mar 29, 2022
@Byron Byron deleted the mailmap branch March 29, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Byron