-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Argh/lean in favor of clap-only #215
Comments
Hey I would be interested to pick this issue, to get familiar with the code base. Do you want clap only or clap with structopt ? |
Thanks for your interest! Maybe I can give you a boost with this illustration: This issue isn't about implementing clap - it is available already - but removing the code path that uses I highly recommend following the collaboration guide, and if there are any additional questions, please let me know here or in the draft PR. |
Thank you, I will give it a shot. |
- remove termion support for linux, use crossterm everywhere. - remove additional 'light' intermediate targets
Otherwise the threaded line renderer will interfere with genuine program output.
…215) Instead, read them eagerly and pass the result on to the closure instead.
…he is used (#215) Note that this is mostly for debugging or quickly seeing if object caches help with certain operations. Ideally the implementation knows themselves and sets up caches accordingly, probably after trying it with these environment variables.
The previous name was too generic to be helpful or discoverable.
… by first commit only (#215) Especially the sorting is useful to avoid having to sort commits by hand after collecting them.
cargo
usesclap
, so can we… it's not worth having multiple code paths for that and it's better to focus on one ultimate commandline arg parser rather than distribute efforts. It's possible to shrink clap for sure.This is the foundation for fixing the long-standing issue of the progress being drawn after the program output was printed. The latter is already fixed for
tui
based progress, and the same solution should then work for the standard progress, too.The text was updated successfully, but these errors were encountered: