refactor

src/plumbing/lean.rs

@@ -33,20 +33,12 @@ use git_features::progress;
 use gitoxide_core as core;
 use std::io::{stderr, stdout};
 
-fn init_log(verbose: bool) {
-    if verbose {
-        env_logger::init_from_env(env_logger::Env::default().default_filter_or("info"));
-    } else {
-        env_logger::init();
-    }
-}
-
 pub fn main() -> Result<()> {
     pub use options::*;
     let cli: Args = argh::from_env();
     match cli.subcommand {
         SubCommands::VerifyPack(VerifyPack { path, verbose }) => {
-            init_log(verbose);
+            super::init_env_logger(verbose);
             core::verify_pack_or_pack_index(
                 path,
                 progress::Log::new("verify-pack").into(),

src/plumbing/mod.rs

@@ -3,3 +3,14 @@ pub mod pretty;
 
 #[cfg(all(feature = "lean-cli", not(feature = "pretty-cli")))]
 pub mod lean;
+
+/// If verbose is true, the env logger will be forcibly set to 'info' logging level. Otherwise env logging facilities
+/// will just be initialized.
+#[cfg(feature = "env_logger")]
+fn init_env_logger(verbose: bool) {
+    if verbose {
+        env_logger::init_from_env(env_logger::Env::default().default_filter_or("info"));
+    } else {
+        env_logger::init();
+    }
+}

src/plumbing/pretty.rs

@@ -33,11 +33,7 @@ mod options {
 }
 
 fn init_progress(name: &str, verbose: bool) -> progress::DoOrDiscard<progress::Log> {
-    if verbose {
-        env_logger::init_from_env(env_logger::Env::default().default_filter_or("info"));
-    } else {
-        env_logger::init();
-    }
+    super::init_env_logger(verbose);
     progress::DoOrDiscard::from(if verbose {
         Some(progress::Log::new(name))
     } else {

tasks.md

@@ -27,7 +27,7 @@
    * **progress**
      * [x] for `lean` binary behind --verbose flag
      * [ ] for `pretty` binary with support for
-       * [ ] logging
+       * [x] logging
        * [ ] TUI
    * [ ] statistics
    * [ ] a verbose mode to list each object in a pack, similar to existing git-verify-pack