Finish removal of rust 2018 idioms

git-object/src/borrowed/id.rs

@@ -64,7 +64,7 @@ impl<'de: 'a, 'a> serde::Deserialize<'de> for Id<'a> {
         }
         impl<'de: 'a, 'a> serde::de::Visitor<'de> for __Visitor<'de, 'a> {
             type Value = Id<'a>;
-            fn expecting(&self, __formatter: &mut serde::export::Formatter) -> serde::export::fmt::Result {
+            fn expecting(&self, __formatter: &mut serde::export::Formatter<'_>) -> serde::export::fmt::Result {
                 serde::export::Formatter::write_str(__formatter, "tuple struct Id")
             }
             #[inline]

git-tui/src/main.rs

@@ -1,4 +1,5 @@
 #![forbid(unsafe_code)]
+#![deny(rust_2018_idioms)]
 
 fn main() {
     unimplemented!();

git-url/src/lib.rs

@@ -1,4 +1,5 @@
 #![forbid(unsafe_code)]
+#![deny(rust_2018_idioms)]
 
 use std::{convert::TryFrom, fmt};
 

gitoxide-core/src/lib.rs

@@ -1,4 +1,5 @@
 #![forbid(unsafe_code)]
+#![deny(rust_2018_idioms)]
 
 use std::str::FromStr;
 

src/plumbing-cli.rs

@@ -1,4 +1,5 @@
 #![forbid(unsafe_code)]
+#![deny(rust_2018_idioms)]
 
 mod plumbing;
 mod shared;

src/porcelain-cli.rs

@@ -1,4 +1,5 @@
 #![forbid(unsafe_code)]
+#![deny(rust_2018_idioms)]
 
 mod porcelain;
 

tasks.md

@@ -6,7 +6,7 @@
     * [x] locate object and figure out how to deal with differences of ODBs databases
     * [x] make NLL issue work
     * [ ] Nice access to compound::Object
-  * [ ] Add #![deny(rust_2018_idioms)] everywhere
+  * [x] Add #![deny(rust_2018_idioms)] everywhere
   * [ ] alternate DB (location - it's really must following the chain until a compound DB can be created)
   * [ ] loose upgrade: jwalk powered iteration behind a feature flag
 * **git-ref**