-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Contributions for New Terms: Please read before creating a PR #62
Comments
What is "category" for? I also see "keywords" in another commit. How are they different? Please give examples too. |
Also, there is a label called "references", but CardList.astro seems to be taking only the first element of the array. Is there a plan to show multiple references in the future? |
Are images mandatory for all terms? Because otherwise the card shows a missing image icon. |
Hello @RayMathew ! Also, no, images are not mandatory and we have to fix the issue of broken images. I was saving that for today, haha 😄 And about the reference, yes, I think it would be good to have multiple references in the future but this feature can wait until we deploy the Astro-integrated website. |
Hello @Buzzpy, Since categories are expected to serve as tags, shouldn't it be like an array of strings? This way, a term can have multiple tags and this will improve the filtering. |
You're right, @bellodamilola. I'll look into that. |
NOTE! I'm updating all cards to say 'categories' and making them an array of strings. Please continue this format for any new cards you create! |
All the new PRs for adding terms should be committed to the branch
develop
, as a JSON File in the directory src/content/terms. Following is the sample structure of the JSON file you can add:File name:
api.json
Note: if you aren't sure about the category, please look at the other terms on the website to get a basic idea. Or, you can keep it as "all", we'll review it and add the category.
Can't wait to see your contributions!
The text was updated successfully, but these errors were encountered: