Rawlink safety

[iemelyanov]

Hi

It looks like Rawlink allows access to one point of memory through mutable and immutable references, which might break Rust aliasing rules. Mb resolve and resolve_mut must be marked as unsafe or even more suitable to use Option<NonNull> instead RawLink?

[BurntSushi]

Can you show an example misuse? Ideally a program that Miri fails on

[iemelyanov]

Sorry, maybe I'm not a correctly named issue. I do not see a problem with using Rawlink. But I try to understand if is it acceptable or idiomatic in terms of Rust for internal API to use carefully something like Rawlink instead for example NonNull?

[BurntSushi]

I would advise you to look at the commit history of the code you're looking at. I wrote it nearly a decade ago. And there is nobody using it. There has been no on-going development either. I don't think you should be drawing any conclusions about idioms from such code.

If the question is just "use NonNull or not," then I think there are reasons to use it and not use it. You'll need to make your own judgment about it.

I only quickly looked at the Rawlink code, and my eye does indeed say it looks suspicious. But I don't have the time or inclination to do a careful review and fix it right now. But PRs are welcome.

[iemelyanov]

Thank you for your answer.