fmt/rfc2822: fix panic in handling of whitespace #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipping whitespace happens immediately before `input[0]`. But skipping the whitespace could lead to `input` being empty. We handle the empty case and add a regression test. Fixes #359
Contributor
|
Well dang...looks like my latest changes introduced this bug in the parser 😮💨 . Really shows the power of fuzz testing though 👀 |
Owner
Author
|
Yeah it was a tricky one. And I missed it in review. I hope to setup fuzzing for Jiff soonish. |
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
May 4, 2025
This upgrades `jiff` to 0.2.12 to fix fuzzing failures. The test case introduced in the previous commit now passes. Upgrading `jiff` past 0.2.11 gets the fix for BurntSushi/jiff#359, fixed in BurntSushi/jiff#360. To avoid declaring compatibility with a version that has the bug, this advances `jiff` from 0.2.10 to 0.2.12 in the `gix-archive` and `gix-date` manifests. (The changes in `Cargo.lock` are those that occur automatically when `cargo check --workspace` is run after those changes.) Fixes GitoxideLabs#1979 Fixes GitoxideLabs#1982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping whitespace happens immediately before
input[0]. But skippingthe whitespace could lead to
inputbeing empty.We handle the empty case and add a regression test.
Fixes #359