We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec claims the titlesByGender dictionary is keyed by the DestinyGender enum
"Destiny.Definitions.Records.DestinyRecordTitleBlock": { "type": "object", "properties": { "hasTitle": { "type": "boolean" }, "titlesByGender": { "type": "object", "additionalProperties": { "type": "string" }, "x-dictionary-key": { "type": "integer", "format": "int32", "x-enum-reference": { "$ref": "#/components/schemas/Destiny.DestinyGender" }, "x-enum-is-bitmask": false } },
but it's actually keyed by two string keys named Male and Female
Male
Female
The text was updated successfully, but these errors were encountered:
Looks like the JSON serialization turns the enum value key into the enum name instead of the int32 value.
would a change to the API spec and docs make the most sense here? Filed as TFS 1055852.
Sorry, something went wrong.
a spec/doc change feels kindest for existing consumers of the data, and if it were keyed by DestinyGender, it would need 3 values, one for 2 (Unknown)
2
We don't have titles for that value, and in this case we don't need the map to be exhaustive for the enum.
No branches or pull requests
spec claims the titlesByGender dictionary is keyed by the DestinyGender enum
but it's actually keyed by two string keys named
Male
andFemale
The text was updated successfully, but these errors were encountered: