vidstabdetect filter fails on these builds

[adamhewitt627]

I am attempting to use the vidstabdetect/vidstabtransform filters.

> ffmpeg -i "input-file.mp4" -vf "vidstabdetect" -f "null" "-"

1. When using the @BtbN build, the created transforms.trf file is binary data (screenshot attached) while the official release build produces a valid text file.
2. I don't care what the TRF file is, except that passing the binary form to vidstabtransform fails.
   • vidstabtransform works on both builds - as long as the TRF is the text instead of the (corrupted?) binary.

@BtbN output

ffmpeg version n6.0-8-g18dde8d4cf-20230317 Copyright (c) 2000-2023 the FFmpeg developers
  built with gcc 12.2.0 (crosstool-NG 1.25.0.90_cf9beb1)
  configuration: --prefix=/ffbuild/prefix --pkg-config-flags=--static --pkg-config=pkg-config 
    --cross-prefix=i686-w64-mingw32- --arch=i686 --target-os=mingw32 --enable-gpl --enable-version3 
    --disable-debug --enable-shared --disable-static --disable-w32threads --enable-pthreads --enable-iconv 
    --enable-libxml2 --enable-zlib --enable-libfreetype --enable-libfribidi --enable-gmp --enable-lzma 
    --enable-fontconfig --enable-libvorbis --enable-opencl --disable-libpulse --enable-libvmaf --disable-libxcb 
    --disable-xlib --enable-amf --enable-libaom --enable-libaribb24 --enable-avisynth --enable-chromaprint 
    --enable-libdav1d --disable-libdavs2 --disable-libfdk-aac --enable-ffnvcodec --enable-cuda-llvm 
    --enable-frei0r --enable-libgme --enable-libkvazaar --enable-libass --enable-libbluray --enable-libjxl 
    --enable-libmp3lame --enable-libopus --enable-librist --enable-libssh --enable-libtheora --enable-libvpx 
    --enable-libwebp --enable-lv2 --disable-libmfx --enable-libvpl --enable-openal --enable-libopencore-amrnb 
    --enable-libopencore-amrwb --enable-libopenh264 --enable-libopenjpeg --enable-libopenmpt --disable-librav1e 
    --enable-librubberband --enable-schannel --enable-sdl2 --enable-libsoxr --enable-libsrt --disable-libsvtav1 
    --enable-libtwolame --disable-libuavs3d --disable-libdrm --disable-vaapi --enable-libvidstab --enable-vulkan 
    --enable-libshaderc --enable-libplacebo --enable-libx264 --enable-libx265 --disable-libxavs2 --enable-libxvid 
    --enable-libzimg --enable-libzvbi --extra-cflags=-DLIBTWOLAME_STATIC --extra-cxxflags= 
    --extra-ldflags=-pthread --extra-ldexeflags= --extra-libs=-lgomp --extra-version=20230317

Official build output

ffmpeg version 6.0-essentials_build-www.gyan.dev Copyright (c) 2000-2023 the FFmpeg developers
  built with gcc 12.2.0 (Rev10, Built by MSYS2 project)
  configuration: --enable-gpl --enable-version3 --enable-static --disable-w32threads --disable-autodetect 
    --enable-fontconfig --enable-iconv --enable-gnutls --enable-libxml2 --enable-gmp --enable-lzma 
    --enable-zlib --enable-libsrt --enable-libssh --enable-libzmq --enable-avisynth --enable-sdl2 
    --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxvid --enable-libaom --enable-libopenjpeg
    --enable-libvpx --enable-libass --enable-libfreetype --enable-libfribidi --enable-libvidstab --enable-libvmaf 
    --enable-libzimg --enable-amf --enable-cuda-llvm --enable-cuvid --enable-ffnvcodec --enable-nvdec 
    --enable-nvenc --enable-d3d11va --enable-dxva2 --enable-libmfx --enable-libgme --enable-libopenmpt 
    --enable-libopencore-amrwb --enable-libmp3lame --enable-libtheora --enable-libvo-amrwbenc 
    --enable-libgsm --enable-libopencore-amrnb --enable-libopus --enable-libspeex --enable-libvorbis 
    --enable-librubberband

[BtbN]

What do you mean by "official release build"? There are no official builds.

Is this based on libvidstab? I have no experience with that set of filters, and thus having a hard time making sense of your report.
Can you try to explain the issue a bit more?

[adamhewitt627]

Looks like I mean the Gyan builds - I don't remember if I used Choco or Winget to install it.

It is based on libvidstab, but it seems that there is a difference in your build configuration with how that gets pulled in. (Stretching my knowledge of C/C++ and how 3rd party code gets compiled in here)

Documentation and examples show that using the filter is simply:

> ffmpeg -i "input-file.mp4" -vf "vidstabdetect" -f "null" "-"

# vidstabdetect creates a TRF file, consumed here to create an output
> ffmpeg -i "input-file.mp4" -vf "vidstabtransform" "output-file.mp4"

[BtbN]

Looking at https://github.com/georgmartius/vid.stab/blob/master/src/serialize.c, it seems like it can produce either binary or text output.
Both are perfectly valid though, and understood just fine by it when reading the file back on. So while a bit curious that it differs between builds (maybe gyan uses an older version of libvidstab, and the default was changed at some point?), it should not cause any issues.

[BtbN]

It even explicitly defaults to the binary serialization mode if it's unset (and ffmpeg never sets it):
https://github.com/georgmartius/vid.stab/blob/master/src/motiondetect.c#L111

So I don't really see how it'd ever end up in text-serialization mode. Is there an entirely different libvidstab out there somewhere, with a compatible API?

[BtbN]

It must relate back to this commit: georgmartius/vid.stab@9d9066d
Pre v1.1.1 (Which advertises itself as v1.2.0 for some reason?!), selecting the serialization format was a compile time option, but even that defaulted to binary.
So the only way I see how Gyans builds could end up with the text output would be if he was a) using an outdated version of libvidstab (1.1.0 or older) and manually opted to configure it for text output.

In any case, it's not an issue, just a different serialization method (if you think it is one for some reason, you need to raise it in ffmpeg trac, so it can select text output again at runtime).

Or are you having any actual issue, other than the file format being different?

[adamhewitt627]

Sounds like you're right, and I found this one also related: georgmartius/vid.stab#104

I opened it here since this environment was the one broken, but looks like it's not in your control. Thank you for the help!

[BtbN]

I'm still trying to understand what exactly is broken.
Are you facing any issues with the binary format, other than it not being human readable in a text editor?
Does reading it back in not work?

[adamhewitt627]

I think vidstab in the BtbN builds is failing to read it back in, but also sounds like a known bug with vidstab. I'm not sure why gyan would be writing it as text, but it looks like that's what is side-stepping the vidstab bug.

[BtbN]

In that case please open a bug in ffmpeg trac.
FFmpeg might have to manually request the text format. The filter does look like it's expecting a text file, given it uses a utf8-specific fopen function.

[GyanD]

I patch vidstab to force it to write ASCII since the 2nd stage filter fopen is U8.
I'll submit a patch in a few days to make it configurable inside the filters.