Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue in README example #18

Open
ibnesayeed opened this issue Feb 8, 2020 · 2 comments
Open

Potential issue in README example #18

ibnesayeed opened this issue Feb 8, 2020 · 2 comments
Labels
question Further information is requested

Comments

@ibnesayeed
Copy link

ibnesayeed commented Feb 8, 2020

Are these GITHUB_REPOSITORY and GITHUB_ACTOR configurations intentional in the README Example? These values are available as environment variables in all runner environments, so why would we namespace them under secrets other than the GITHUB_TOKEN that is created by the user?

        env: 
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          GITHUB_REPOSITORY: ${{ secrets.GITHUB_REPOSITORY }}
          GITHUB_ACTOR: ${{ secrets.GITHUB_ACTOR }}
@evanw555
Copy link

github.repository and github.actor seemed to work for me.

@BryanSchuetz
Copy link
Owner

I'll have to look at the documentation again—at some point, I think it did have to be explicitly set but maybe that's no longer true.

@BryanSchuetz BryanSchuetz added the question Further information is requested label Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants